Elveneleven wrote:Hi there.
First of all I have to thank tytung, marco.palumbi and agbommarito for this wonderful fast new v2.5 rom (all credits to tytung) with working bluetooth tethering (credits to marco.palumbi) and softkey/Powerbutton mod (credits to agbommarito)
While using and playing with the rom i found some issues with the softkeys /Navbar. Nothing big. It's more cosmetics but i hope agbommarito wants to fix it (I'm sure he can if he got time)
Here we go:
As you can see in the Screenshots below spacing and arrangement of the buttons in portrait and landscape is perfect when using a 3 or 4 button layout.
If you're using a 5 button Layout (like me) spacing is incorrect resulting in asymmetric location of the buttons in both portrait and landscape.
When using a 6 button Layout spacing in landscape is perfect due to agbommarito's work but in portrait button 1 and 2 just like 5 and 6 are nearby so it's difficult to hit the right button. Spacing im portrait could be a bit optimized.


Another issue i found is in fullscreen mode. As you can see in the Screenshot the softkey bar seems to be cut off at the left and right border. So if you're using more than 3 buttons you cannot access them correctly.

Third thing affects the Navbar height which is currently 30 or 36 dpi.
It's just a suggestion but it think it would be a benefit. For me a Navbar /softkeybar height of 24 dpi is optimal which I tested with several roms. It's high enough to hit the buttons correct and it gives you a bit more space on the screen. And we all know the hd2 screen with it's 480x800 resolution isn't the biggest although it's big enough.
I also think reducing the Navbar height to 24 dpi will probably solve the cut off date on the lockscreen making agbommarito's fix obsolete. (btw. You did a great Job with the fix. Credits to agbommarito)
Ok. That's it. Hopefully i could help making the best rom better.
Sent with Tapatalk 4 beta
I wanted to give you some feedback on your suggestions.
The issue of the softkey size is a tricky one. The following discussion is just my understanding of how things work, which probably isn't completely correct as it is based only on my two Android devices, an HD2 and a Nexus7.
Android itself is built with the notion of 3 softkey buttons. They aren't changeable. There is the possibility of a fourth softkey, the three vertical dots at the very left. But this is only used for misbehaving programs that don't conform to the latest Android guidelines of handling the menu button within the program.
CyanogenMod adds the additional softkeys and the means to program them. The outer softkeys, the ones on the very right and very left, are treated specially. The Cyanogen code calls these side buttons, and requires special icons for them that are smaller than the icons for the middle three softkeys. Your idea of spacing all programmed softkeys equally across the screen is, in my opinion, a good one. The screen presentation would look better if the software did that. But implementing the idea is quite complicated and would require numerous changes within the CyanogenMod code base. What I do in adding the power button is, quite literally, a patch. I use a tool called apktool to disassemble the Java code for one module, make some minor changes, then reassemble the module and package it for flashing. Doing the equal spacing mod would be an extensive project and would be very hard to maintain with a constantly changing CyanogenMod code base. I wouldn't be able to devote the time needed for such an undertaking.
The fullscreen cutoff problem looks to me like a bug in the Cyanogen code. I suggest reporting it to them using their issue tracker at
http://wiki.cyanogenmod.org/w/Jira.
The idea of a navigation bar that is not as high as default is very easy to implement. I'll keep it on my to-do list for the next time Tytung changes the ROM and see if I can come up with an option for that.